Skip to content

Remove constraints [wip] #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove constraints [wip] #46

wants to merge 3 commits into from

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 13, 2023 •
edited
Loading

this is a start on a removeConstraint method.

  • It's currently implemented for the SCIP backend, but not gurobi.
  • it works, however, if I add an unsatisfiable constraint and try to solve before removing the incompatible constraint, it leaves the solver unable to recover, even if I later make it satisfiable again.

(these lines are shown during the failed solve)

[scip_prob.c:2883] ERROR: invalid SCIP stage <10>
[ScipBackend.cpp:315] ERROR: Error <-8> in function call
[scip_prob.c:2883] ERROR: invalid SCIP stage <10>
[ScipBackend.cpp:315] ERROR: Error <-8> in function call
[scip_cons.c:1148] ERROR: cannot release last use of original constraint while an associated transformed constraint exists
[ScipBackend.cpp:317] ERROR: Error <-8> in function call
[scip_prob.c:2883] ERROR: invalid SCIP stage <10>
[ScipBackend.cpp:315] ERROR: Error <-8> in function call

tlambert03
tlambert03 commented Nov 13, 2023
View reviewed changes
ilpy/impl/solvers/SolverBackend.h
@@ -6,10 +6,10 @@
#include "Solution.h"
#include "VariableType.h"

class SolverBackend {
class SolverBackend
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about the auto-formatting, will remove and reduce the diff

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (7fac186) to head (599ac42).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
ilpy/wrapper.pyx 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #46       +/-   ##
===========================================
+ Coverage   75.72%   92.30%   +16.58%     
===========================================
  Files          17        4       -13     
  Lines         828      390      -438     
  Branches      154        0      -154     
===========================================
- Hits          627      360      -267     
+ Misses        136       30      -106     
+ Partials       65        0       -65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
Copy link
Member Author

while this is still a needed feature, this particular PR is no longer relevant following #70

@tlambert03 tlambert03 closed this Apr 14, 2025
@tlambert03 tlambert03 mentioned this pull request Apr 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tlambert03